updated refs to github repos

Multiple responses to relationship questions

.gitignore

@@ -18,3 +18,4 @@ dist/
 *.ps
 *.toc
 *.gz
+index.html

README.md

@@ -4,7 +4,7 @@ A pure JavaScript implementation of the ITA project's CEStore - called CENode. C
 
 Please visit the project's [home page](http://cenode.io) for more information and for documentation.
 
-See also the [Getting Started Tutorial](https://github.com/flyingsparx/CENode/blob/master/docs/getting_started.md).
+**We recommend beginners check out the [Getting Started Guide](https://github.com/willwebberley/CENode/wiki/Getting-Started-Guide) before continuing.**
 
 ## Getting started
 
@@ -12,7 +12,7 @@ CENode can be imported into your Node apps or run in a browser. Either way, you
 
 Then add CENode to your project using NPM:
 ```
-npm install
+npm install cenode
 ```
 
 If using CENode in a webpage, then include it (and models, if necessary) in script tags:
@@ -33,13 +33,13 @@ const CEModels = require('cenode/models'); // if requred
 const node = new CENode(CEModels.core);
 ```
 
-See the [Wiki](https://github.com/flyingsparx/CENode/wiki) for further guides and the API reference.
+See the [Wiki](https://github.com/willwebberley/CENode/wiki) for further guides and the API reference.
 
 ## Testing
 
 Clone the repository
 ```
-git clone git@github.com:flyingsparx/CENode.git
+git clone git@github.com:willwebberley/CENode.git
 ```
 
 Install the necessary dev dependencies.
@@ -54,7 +54,7 @@ npm test
 
 ## More Information
 
-See the CENode [Wiki](https://github.com/flyingsparx/CENode/wiki) for more information, guides, and the API reference.
+See the CENode [Wiki](https://github.com/willwebberley/CENode/wiki) for more information, guides, and the API reference.
 
 
 ## Licence

models/core.js

@@ -18,6 +18,7 @@ module.exports = [
   "conceptualise a ~ policy ~ P that is an entity and has the value V as ~ enabled ~ and has the agent A as ~ target ~",
   "conceptualise a ~ tell policy ~ P that is a policy",
   "conceptualise an ~ ask policy ~ P that is a policy",
+  "conceptualise a ~ gist policy ~ P that is a policy",
   "conceptualise a ~ listen policy ~ P that is a policy",
   "conceptualise a ~ listen onbehalfof policy ~ P that is a policy",
   "conceptualise a ~ forwardall policy ~ P that is a policy and has the timestamp T as ~ start time ~ and has the value V as ~ all agents ~",

package.json

@@ -1,13 +1,13 @@
 {
   "name": "cenode",
-  "version": "3.0.2",
+  "version": "3.0.12",
   "description": "A pure JavaScript implementation of the ITA project's CEStore - called CENode. CENode is able to understand the basic sentence types parsed by the CEStore, such as conceptualising and instance creation and modification.",
   "homepage": "http://cenode.io",
   "license": "Apache-2.0",
   "author": "Will Webberley & Alun Preece",
   "repository": {
     "type": "git",
-    "url": "https://github.com/flyingsparx/CENode"
+    "url": "https://github.com/willwebberley/CENode"
   },
   "files": [
     "src",

src/CEAgent.js

@@ -43,9 +43,9 @@ class CEAgent {
 
   getInstance() {
     const instances = this.node.getInstances('agent');
-    for (let i = 0; i < instances.length; i += 1) {
+    for (const instance of instances) {
-      if (instances[i].name.toLowerCase() === name.toLowerCase()) {
+      if (instance.name.toLowerCase() === name.toLowerCase()) {
-        return instances[i];
+        return instance;
       }
     }
     return null;

src/CEConcept.js

@@ -19,6 +19,14 @@
 class CEConcept {
 
   constructor(node, name, source) {
+    if (!name) {
+      return;
+    }
+    for (const concept of node.concepts) {
+      if (concept.name.toLowerCase() === name.toLowerCase()) {
+        return;
+      }
+    }
     this.name = name;
     this.source = source;
     this.id = node.newConceptId();
@@ -30,6 +38,7 @@ class CEConcept {
     node.concepts.push(this);
     this.node.conceptDict[this.id] = this;
 
+    if (isNaN(name[0])) {
       const concept = this;
       Object.defineProperty(node.concepts, name.toLowerCase().replace(/ /g, '_'), {
         get() {
@@ -38,91 +47,92 @@ class CEConcept {
         configurable: true,
       });
     }
+  }
 
   get instances() {
-    const instances = [];
+    const array = [];
-    for (let i = 0; i < this.node.instances.length; i += 1) {
+    for (const instance of this.node.instances) {
-      if (this.node.instances[i].type.id === this.id) {
+      if (instance.concept.id === this.id) {
-        instances.push(this.node.instances[i]);
+        array.push(instance);
       }
     }
-    return instances;
+    return array;
   }
 
   get allInstances() {
     const allConcepts = this.descendants.concat(this);
-    const instances = [];
+    const array = [];
-    for (let i = 0; i < this.node.instances.length; i += 1) {
+    for (const instance of this.node.instances) {
-      for (let j = 0; j < allConcepts.length; j += 1) {
+      for (const concept of allConcepts) {
-        if (this.node.instances[i].type.id === allConcepts[j].id) {
+        if (instance.concept.id === concept.id) {
-          instances.push(this.node.instances[i]);
+          array.push(instance);
         }
       }
     }
-    return instances;
+    return array;
   }
 
   get parents() {
-    const p = [];
+    const array = [];
-    for (let i = 0; i < this.parentIds.length; i += 1) {
+    for (const id of this.parentIds) {
-      p.push(this.node.getConceptById(this.parentIds[i]));
+      array.push(this.node.getConceptById(id));
     }
-    return p;
+    return array;
   }
 
   get ancestors() {
-    const parents = [];
+    const array = [];
     const stack = [];
-    for (let i = 0; i < this.parentIds.length; i += 1) {
+    for (const parent of this.parents) {
-      stack.push(this.parents[i]);
+      stack.push(parent);
     }
     while (stack.length > 0) {
       const current = stack.pop();
-      parents.push(current);
+      array.push(current);
-      for (let i = 0; i < current.parents.length; i += 1) {
+      for (const parent of current.parents) {
-        stack.push(current.parents[i]);
+        stack.push(parent);
       }
     }
-    return parents;
+    return array;
   }
 
   get children() {
-    const children = [];
+    const array = [];
-    for (let i = 0; i < this.node.concepts.length; i += 1) {
+    for (const concept of this.node.concepts) {
-      for (let j = 0; j < this.node.concepts[i].parents.length; j += 1) {
+      for (const parent of concept.parents) {
-        if (this.node.concepts[i].parents[j].id === this.id) {
+        if (parent.id === this.id) {
-          children.push(this.node.concepts[i]);
+          array.push(concept);
         }
       }
     }
-    return children;
+    return array;
   }
 
   get descendants() {
-    const children = [];
+    const array = [];
     const stack = [];
-    for (let i = 0; i < this.children.length; i += 1) {
+    for (const child of this.children) {
-      stack.push(this.children[i]);
+      stack.push(child);
     }
     while (stack.length > 0) {
       const current = stack.pop();
-      children.push(current);
+      array.push(current);
       const currentChildren = current.children;
       if (currentChildren) {
-        for (let i = 0; i < currentChildren.length; i += 1) {
+        for (const child of currentChildren) {
-          stack.push(currentChildren[i]);
+          stack.push(child);
         }
       }
     }
-    return children;
+    return array;
   }
 
   get relationships() {
     const rels = [];
-    for (let i = 0; i < this.relationshipIds.length; i += 1) {
+    for (const id of this.relationshipIds) {
       const relationship = {};
-      relationship.label = this.relationshipIds[i].label;
+      relationship.label = id.label;
-      relationship.concept = this.node.getConceptById(this.relationshipIds[i].target);
+      relationship.concept = this.node.getConceptById(id.target);
       rels.push(relationship);
     }
     return rels;
@@ -130,60 +140,61 @@ class CEConcept {
 
   get values() {
     const vals = [];
-    for (let i = 0; i < this.valueIds.length; i += 1) {
+    for (const val of this.valueIds) {
       const value = {};
-      value.label = this.valueIds[i].label;
+      value.label = val.label;
-      if (this.valueIds[i].conceptId === 0) {
+      value.concept = val.type && this.node.getConceptById(val.type);
-        value.concept = this.valueIds[i].typeName;
-      } else {
-        value.concept = this.node.getConceptById(this.valueIds[i].type);
-      }
       vals.push(value);
     }
     return vals;
   }
 
-  get ce() {
+  getCE(isModification) {
-    let ce = `conceptualise a ~ ${this.name} ~ ${this.name.charAt(0).toUpperCase()}`;
+    let ce = '';
-    if (this.parentIds.length > 0 || this.valueIds.length > 0 || this.relationshipIds.length > 0) {
+    if (isModification) {
+      ce += `conceptualise the ${this.name} ${this.name.charAt(0).toUpperCase()}`;
+    } else {
+      ce += `conceptualise a ~ ${this.name} ~ ${this.name.charAt(0).toUpperCase()}`;
+    }
+    if (!isModification && (this.parentIds.length > 0 || this.valueIds.length > 0 || this.relationshipIds.length > 0)) {
       ce += ' that';
     }
     if (this.parentIds.length > 0) {
-      for (let i = 0; i < this.parentIds.length; i += 1) {
+      for (let i = 0; i < this.parents.length; i += 1) {
-        ce += ` is a ${this.parentIds[i].name}`;
+        ce += ` is a ${this.parents[i].name}`;
-        if (i < this.parentIds.length - 1) { ce += ' and'; }
+        if (i < this.parents.length - 1) { ce += ' and'; }
       }
     }
-    let facts = [];
+    const facts = [];
     const alph = ['A', 'B', 'C', 'D', 'E', 'F', 'G', 'H', 'I', 'J', 'K', 'L', 'M', 'N', 'O'];
     for (let i = 0; i < this.valueIds.length; i += 1) {
       if (this.valueIds[i].type === 0) {
-        facts.push(`has the value ${alph[i]} as ${this.valueIds[i].label}`);
+        facts.push(`has the value ${alph[i]} as ~ ${this.valueIds[i].label} ~`);
       } else {
         const valType = this.node.getConceptById(this.valueIds[i].type);
-        facts.push(`has the ${valType.name} ${valType.name.charAt(0).toUpperCase()} as ${this.valueIds[i].label}`);
+        facts.push(`has the ${valType.name} ${valType.name.charAt(0).toUpperCase()} as ~ ${this.valueIds[i].label} ~`);
       }
     }
+    for (let i = 0; i < this.relationshipIds.length; i += 1) {
+      const relType = this.node.getConceptById(this.relationshipIds[i].target);
+      facts.push(`~ ${this.relationshipIds[i].label} ~ the ${relType.name} ${alph[i]}`);
+    }
     if (facts.length > 0) {
       if (this.parentIds.length > 0) { ce += ' and'; }
       ce += ` ${facts.join(' and ')}`;
     }
     ce += '.';
-    if (this.relationshipIds.length > 0) {
-      facts = [];
-      ce += `\nconceptualise the ${this.name} ${this.name.charAt(0).toUpperCase()}`;
-      for (let i = 0; i < this.relationshipIds.length; i += 1) {
-        const relType = this.node.getConceptById(this.relationshipIds[i].target);
-        facts.push(`~ ${this.relationshipIds[i].label} ~ the ${relType.name} ${alph[i]}`);
-      }
-      if (facts.length > 0) {
-        if (this.parentIds.length > 0 || this.valueIds.length > 0) { ce += ' and'; }
-        ce += ` ${facts.join(' and ')}.`;
-      }
-    }
     return ce;
   }
 
+  get creationCE() {
+    return `conceptualise a ~ ${this.name} ~ ${this.name.charAt(0).toUpperCase()}`;
+  }
+
+  get ce() {
+    return this.getCE();
+  }
+
   get gist() {
     let gist = '';
     if (this.parentIds.length > 0) { gist += `A ${this.name}`; }
@@ -219,6 +230,7 @@ class CEConcept {
     value.label = label;
     value.type = typeof type === 'number' ? type : type.id;
     this.valueIds.push(value);
+    if (isNaN(label[0])) {
       Object.defineProperty(this, label.toLowerCase().replace(/ /g, '_'), {
         get() {
           return type === 0 ? 'value' : type;
@@ -226,6 +238,7 @@ class CEConcept {
         configurable: true,
       });
     }
+  }
 
   addRelationship(label, target, source) {
     const relationship = {};
@@ -233,6 +246,7 @@ class CEConcept {
     relationship.label = label;
     relationship.target = target.id;
     this.relationshipIds.push(relationship);
+    if (isNaN(label[0])) {
       Object.defineProperty(this, label.toLowerCase().replace(/ /g, '_'), {
         get() {
           return target;
@@ -240,6 +254,7 @@ class CEConcept {
         configurable: true,
       });
     }
+  }
 
   addParent(parentConcept) {
     if (this.parentIds.indexOf(parentConcept.id) === -1) {
@@ -248,8 +263,8 @@ class CEConcept {
   }
 
   addSynonym(synonym) {
-    for (let i = 0; i < this.synonyms.length; i += 1) {
+    for (const currentSynonym of this.synonyms) {
-      if (this.synonyms[i].toLowerCase() === synonym.toLowerCase()) {
+      if (currentSynonym.toLowerCase() === synonym.toLowerCase()) {
         return;
       }
     }

src/CEInstance.js

@@ -19,10 +19,14 @@
 class CEInstance {
 
   constructor(node, type, name, source) {
-    if (!type) {
+    if (!type || !name) {
       return;
     }
-
+    for (const instance of node.instances) {
+      if (instance.name.toLowerCase() === name.toLowerCase() && type.id === instance.concept.id) {
+        return;
+      }
+    }
     this.node = node;
     this.name = name;
     this.source = source;
@@ -38,26 +42,28 @@ class CEInstance {
     node.instances.push(this);
     this.node.instanceDict[this.id] = this;
 
+    if (isNaN(name[0])) {
       const instance = this;
-    Object.defineProperty(node.instances, name.toLowerCase().replace(/ /g, '_').replace(/'/g, ''), {
+      const helperName = name.toLowerCase().replace(/ /g, '_').replace(/'/g, '');
+      Object.defineProperty(node.instances, helperName, {
         get() {
           return instance;
         },
         configurable: true,
       });
-
+      Object.defineProperty(type, helperName, {
-    Object.defineProperty(type, name.toLowerCase(), {
         get() {
           return instance;
         },
         configurable: true,
       });
     }
+  }
 
   get type() {
-    for (let i = 0; i < this.node.concepts.length; i += 1) {
+    for (const concept of this.node.concepts) {
-      if (this.node.concepts[i].id === this.concept.id) {
+      if (concept.id === this.concept.id) {
-        return this.node.concepts[i];
+        return concept;
       }
     }
     return null;
@@ -65,11 +71,11 @@ class CEInstance {
 
   get relationships() {
     const rels = [];
-    for (let i = 0; i < this.relationshipIds.length; i += 1) {
+    for (const id of this.relationshipIds) {
       const relationship = {};
-      relationship.label = this.relationshipIds[i].label;
+      relationship.label = id.label;
-      relationship.source = this.relationshipIds[i].source;
+      relationship.source = id.source;
-      relationship.instance = this.node.getInstanceById(this.relationshipIds[i].targetId);
+      relationship.instance = this.node.getInstanceById(id.targetId);
       rels.push(relationship);
     }
     return rels;
@@ -77,14 +83,14 @@ class CEInstance {
 
   get values() {
     const vals = [];
-    for (let i = 0; i < this.valueIds.length; i += 1) {
+    for (const id of this.valueIds) {
       const value = {};
-      value.label = this.valueIds[i].label;
+      value.label = id.label;
-      value.source = this.valueIds[i].source;
+      value.source = id.source;
-      if (this.valueIds[i].conceptId === 0) {
+      if (id.conceptId === 0) {
-        value.instance = this.valueIds[i].typeName;
+        value.instance = id.typeName;
       } else {
-        value.instance = this.node.getInstanceById(this.valueIds[i].conceptId);
+        value.instance = this.node.getInstanceById(id.conceptId);
       }
       vals.push(value);
     }
@@ -96,15 +102,19 @@ class CEInstance {
   }
 
   getPossibleProperties() {
-    const ancestorInstances = this.concept.ancestors;
+    let ancestorInstances = this.concept.ancestors;
     ancestorInstances.push(this.concept);
-    const properties = { values: [], relationships: [] };
+    for (const subConcept of this.subConcepts) {
-    for (let i = 0; i < ancestorInstances.length; i += 1) {
+      ancestorInstances.push(subConcept);
-      for (let j = 0; j < ancestorInstances[i].values.length; j += 1) {
+      ancestorInstances = ancestorInstances.concat(subConcept.ancestors);
-        properties.values.push(ancestorInstances[i].values[j].label.toLowerCase());
     }
-      for (let j = 0; j < ancestorInstances[i].relationships.length; j += 1) {
+    const properties = { values: [], relationships: [] };
-        properties.relationships.push(ancestorInstances[i].relationships[j].label.toLowerCase());
+    for (const ancestor of ancestorInstances) {
+      for (const value of ancestor.values) {
+        properties.values.push(value.label.toLowerCase());
+      }
+      for (const relationship of ancestor.relationships) {
+        properties.relationships.push(relationship.label.toLowerCase());
       }
     }
     return properties;
@@ -123,7 +133,7 @@ class CEInstance {
       this.valueIds.push(value);
       const valueNameField = label.toLowerCase().replace(/ /g, '_');
 
-      if (this.reservedFields.indexOf(valueNameField) === -1) {
+      if (this.reservedFields.indexOf(valueNameField) === -1 && isNaN(valueNameField[0])) {
         Object.defineProperty(this, valueNameField, {
           get() {
             return value.conceptId === 0 ? value.typeName : this.node.getInstanceById(value.conceptId);
@@ -135,9 +145,9 @@ class CEInstance {
           Object.defineProperty(this, `${valueNameField}s`, {
             get() {
               const instances = [];
-              for (let i = 0; i < this.valueIds.length; i += 1) {
+              for (const id of this.valueIds) {
-                if (this.valueIds[i].label.toLowerCase().replace(/ /g, '_') === valueNameField) {
+                if (id.label.toLowerCase().replace(/ /g, '_') === valueNameField) {
-                  instances.push(this.valueIds[i].conceptId === 0 ? this.valueIds[i].typeName : this.node.getInstanceById(this.valueIds[i].conceptId));
+                  instances.push(id.conceptId === 0 ? id.typeName : this.node.getInstanceById(id.conceptId));
                 }
               }
               return instances;
@@ -162,7 +172,7 @@ class CEInstance {
       this.relationshipIds.push(relationship);
       const relNameField = label.toLowerCase().replace(/ /g, '_');
 
-      if (this.reservedFields.indexOf(relNameField) === -1) {
+      if (this.reservedFields.indexOf(relNameField) === -1 && isNaN(relNameField[0])) {
         Object.defineProperty(this, relNameField, {
           get() {
             return this.node.getInstanceById(relationship.targetId);
@@ -174,9 +184,9 @@ class CEInstance {
           Object.defineProperty(this, `${relNameField}s`, {
             get() {
               const instances = [];
-              for (let i = 0; i < this.relationshipIds.length; i += 1) {
+              for (const id of this.relationshipIds) {
-                if (this.relationshipIds[i].label.toLowerCase().replace(/ /g, '_') === relNameField) {
+                if (id.label.toLowerCase().replace(/ /g, '_') === relNameField) {
-                  instances.push(this.node.getInstanceById(this.relationshipIds[i].targetId));
+                  instances.push(this.node.getInstanceById(id.targetId));
                 }
               }
               return instances;
@@ -195,17 +205,19 @@ class CEInstance {
     if (!synonym || !synonym.length) {
       return null;
     }
-    for (let i = 0; i < this.synonyms.length; i += 1) {
+    for (const checkSynonym of this.synonyms) {
-      if (this.synonyms[i].toLowerCase() === synonym.toLowerCase()) {
+      if (checkSynonym.toLowerCase() === synonym.toLowerCase()) {
         return null;
       }
     }
     this.synonyms.push(synonym);
+    if (isNaN(synonym[0])) {
       Object.defineProperty(this, synonym.toLowerCase().replace(/ /g, '_'), {
         get() {
           return this;
         },
       });
+    }
     return null;
   }
 
@@ -250,69 +262,79 @@ class CEInstance {
     return onlyOne ? null : properties;
   }
 
-  get ce() {
+  getCE(isModification) {
     const concept = this.concept;
     if (!concept) { return ''; }
-    let ce = `there is a ${concept.name} named '${this.name}'`;
+
+    let ce = '';
+    if (isModification) {
+      ce += `the ${concept.name} '${this.name}'`;
+    } else {
+      ce += `there is a ${concept.name} named '${this.name}'`;
+    }
     const facts = [];
     for (const subConcept of this.subConcepts) {
       facts.push(`is a ${subConcept.name}`);
     }
-    for (let i = 0; i < this.valueIds.length; i += 1) {
+    for (const id of this.valueIds) {
-      const value = this.valueIds[i];
+      if (id.conceptId === 0) {
-      if (value.conceptId === 0) {
+        facts.push(`has '${id.typeName.replace(/'/g, "\\'")}' as ${id.label}`);
-        facts.push(`has '${value.typeName.replace(/'/g, "\\'")}' as ${value.label}`);
       } else {
-        const valueInstance = this.node.getInstanceById(value.conceptId);
+        const valueInstance = this.node.getInstanceById(id.conceptId);
         const valueConcept = valueInstance.type;
-        facts.push(`has the ${valueConcept.name} '${valueInstance.name}' as ${value.label}`);
+        facts.push(`has the ${valueConcept.name} '${valueInstance.name}' as ${id.label}`);
       }
     }
-    for (let i = 0; i < this.relationshipIds.length; i += 1) {
+    for (const id of this.relationshipIds) {
-      const relationship = this.relationshipIds[i];
+      const relationshipInstance = this.node.getInstanceById(id.targetId);
-      const relationshipInstance = this.node.getInstanceById(relationship.targetId);
       const relationshipConcept = relationshipInstance.type;
-      facts.push(`${relationship.label} the ${relationshipConcept.name} '${relationshipInstance.name}'`);
+      facts.push(`${id.label} the ${relationshipConcept.name} '${relationshipInstance.name}'`);
     }
-    if (facts.length > 0) { ce += ` that ${facts.join(' and ')}`; }
+    if (facts.length > 0) { ce += `${!isModification && ' that'} ${facts.join(' and ')}`; }
     return `${ce}.`;
   }
 
+  get creationCE() {
+    return `there is a ${this.concept && this.concept.name} named '${this.name}'`;
+  }
+
+  get ce() {
+    return this.getCE();
+  }
+
   get gist() {
     const vowels = ['a', 'e', 'i', 'o', 'u'];
     const concept = this.concept;
     if (!concept) { return ''; }
     let gist = `${this.name} is`;
-    if (vowels.indexOf(concept.name.toLowerCase()[0]) > -1) { gist += ` an ${concept.name}.`; } else { gist += ` a ${concept.name}`; }
+    if (vowels.indexOf(concept.name.toLowerCase()[0]) > -1) { gist += ` an ${concept.name}`; } else { gist += ` a ${concept.name}`; }
-    for (let i = 0; i < this.subConcepts.length; i += 1) {
+    for (const subConcept of this.subConcepts) {
-      gist += ` and a ${this.subConcepts[i].name}`;
+      gist += ` and ${vowels.indexOf(subConcept.name.toLowerCase()[0]) > -1 ? 'an' : 'a'} ${subConcept.name}`;
     }
     gist += '.';
 
     const facts = {};
     let factFound = false;
-    for (let i = 0; i < this.valueIds.length; i += 1) {
+    for (const id of this.valueIds) {
       factFound = true;
-      const value = this.valueIds[i];
       let fact = '';
-      if (value.conceptId === 0) {
+      if (id.conceptId === 0) {
-        fact = `has '${value.typeName.replace(/'/g, "\\'")}' as ${value.label}`;
+        fact = `has '${id.typeName.replace(/'/g, "\\'")}' as ${id.label}`;
       } else {
-        const valueInstance = this.node.getInstanceById(value.conceptId);
+        const valueInstance = this.node.getInstanceById(id.conceptId);
         const valueConcept = valueInstance.type;
-        fact = `has the ${valueConcept.name} '${valueInstance.name}' as ${value.label}`;
+        fact = `has the ${valueConcept.name} '${valueInstance.name}' as ${id.label}`;
       }
       if (!(fact in facts)) {
         facts[fact] = 0;
       }
       facts[fact] += 1;
     }
-    for (let i = 0; i < this.relationshipIds.length; i += 1) {
+    for (const id of this.relationshipIds) {
       factFound = true;
-      const relationship = this.relationshipIds[i];
+      const relationshipInstance = this.node.getInstanceById(id.targetId);
-      const relationshipInstance = this.node.getInstanceById(relationship.targetId);
       const relationshipConcept = relationshipInstance.type;
-      const fact = `${relationship.label} the ${relationshipConcept.name} '${relationshipInstance.name}'`;
+      const fact = `${id.label} the ${relationshipConcept.name} '${relationshipInstance.name}'`;
       if (!(fact in facts)) {
         facts[fact] = 0;
       }

src/CENode.js

@@ -46,13 +46,13 @@ class CENode {
 
   getConceptByName(name) {
     if (!name) { return null; }
-    for (let i = 0; i < this.concepts.length; i += 1) {
+    for (const concept of this.concepts) {
-      if (this.concepts[i].name.toLowerCase() === name.toLowerCase()) {
+      if (concept.name.toLowerCase() === name.toLowerCase()) {
-        return this.concepts[i];
+        return concept;
       }
-      for (let j = 0; j < this.concepts[i].synonyms.length; j += 1) {
+      for (const synonym of concept.synonyms) {
-        if (this.concepts[i].synonyms[j].toLowerCase() === name.toLowerCase()) {
+        if (synonym.toLowerCase() === name.toLowerCase()) {
-          return this.concepts[i];
+          return concept;
         }
       }
     }
@@ -63,15 +63,18 @@ class CENode {
     return this.instanceDict[id];
   }
 
-  getInstanceByName(name) {
+  getInstanceByName(name, concept) {
     if (!name) { return null; }
-    for (let i = 0; i < this.instances.length; i += 1) {
+    const possibleConcepts = concept ? [concept.id].concat(concept.ancestors.map(ancestor => ancestor.id)).concat(concept.descendants.map(descendant => descendant.id)) : [];
-      if (this.instances[i].name.toLowerCase() === name.toLowerCase()) {
+    for (const instance of this.instances) {
-        return this.instances[i];
+      if (instance && (concept ? possibleConcepts.indexOf(instance.concept.id) > -1 : true)) {
+        if (instance.name.toLowerCase() === name.toLowerCase()) {
+          return instance;
+        }
+        for (const synonym of instance.synonyms) {
+          if (synonym.toLowerCase() === name.toLowerCase()) {
+            return instance;
           }
-      for (let j = 0; j < this.instances[i].synonyms.length; j += 1) {
-        if (this.instances[i].synonyms[j].toLowerCase() === name.toLowerCase()) {
-          return this.instances[i];
         }
       }
     }
@@ -95,15 +98,17 @@ class CENode {
    * Returns: [obj{instance}]
    */
   getInstances(conceptType, recurse) {
-    let instanceList = [];
+    const instanceList = [];
     if (!conceptType) {
-      instanceList = this.instances;
+      for (const instance of this.instances) {
+        instanceList.push(instance);
+      }
     } else if (conceptType && !recurse) {
       const concept = this.getConceptByName(conceptType);
       if (concept) {
-        for (let i = 0; i < this.instances.length; i += 1) {
+        for (const instance of this.instances) {
-          if (this.instances[i].type.id === concept.id) {
+          if (instance && instance.concept.id === concept.id) {
-            instanceList.push(this.instances[i]);
+            instanceList.push(instance);
           }
         }
       }
@@ -112,10 +117,10 @@ class CENode {
       if (concept) {
         const descendants = concept.descendants.concat(concept);
         const childrenIds = [];
-        for (let i = 0; i < descendants.length; i += 1) { childrenIds.push(descendants[i].id); }
+        for (const descendant of descendants) { childrenIds.push(descendant.id); }
-        for (let i = 0; i < this.instances.length; i += 1) {
+        for (const instance of this.instances) {
-          if (childrenIds.indexOf(this.instances[i].type.id) > -1) {
+          if (instance && childrenIds.indexOf(instance.concept.id) > -1) {
-            instanceList.push(this.instances[i]);
+            instanceList.push(instance);
           }
         }
       }
@@ -132,12 +137,12 @@ class CENode {
    */
   addSentence(sentence, source) {
     const ceResult = this.addCE(sentence, false, source);
-    if (ceResult.success) {
+    if (!ceResult.error) {
       return ceResult;
     }
 
     const questionResult = this.askQuestion(sentence);
-    if (questionResult.success) {
+    if (!questionResult.error) {
       return questionResult;
     }
 
@@ -151,8 +156,8 @@ class CENode {
    */
   addSentences(sentences, source) {
     const responses = [];
-    for (let i = 0; i < sentences.length; i += 1) {
+    for (const sentence of sentences) {
-      responses.push(this.addSentence(sentences[i], source));
+      responses.push(this.addSentence(sentence, source));
     }
     return responses;
   }
@@ -165,13 +170,7 @@ class CENode {
    * Returns: {success: bool, type: str, data: str}
    */
   addCE(sentence, source) {
-    const success = this.ceParser.parse(sentence.trim().replace('{now}', new Date().getTime()).replace('{uid}', this.newCardId()), source);
+    return this.ceParser.parse(sentence.trim().replace('{now}', new Date().getTime()).replace('{uid}', this.newCardId()), source);
-    return {
-      success: success[0],
-      type: 'gist',
-      data: success[1],
-      result: success[2] || undefined,
-    };
   }
 
   /*
@@ -181,12 +180,7 @@ class CENode {
    * Returns: {success: bool, type: str, data: str}
    */
   askQuestion(sentence) {
-    const success = this.questionParser.parse(sentence);
+    return this.questionParser.parse(sentence);
-    return {
-      success: success[0],
-      type: success[0] ? 'gist' : undefined,
-      data: success[0] ? success[1] : undefined,
-    };
   }
 
   /*
@@ -196,11 +190,7 @@ class CENode {
    * Returns: {type: str, data: str}
    */
   addNL(sentence) {
-    const success = this.nlParser.parse(sentence);
+    return this.nlParser.parse(sentence);
-    return {
-      type: success[0] ? 'confirm' : 'gist',
-      data: success[1],
-    };
   }
 
   /*
@@ -210,8 +200,10 @@ class CENode {
    */
   loadModel(sentences) {
     const responses = [];
-    for (let i = 0; i < sentences.length; i += 1) {
+    if (sentences && sentences.length) {
-      responses.push(this.addCE(sentences[i]));
+      for (const sentence of sentences) {
+        responses.push(this.addCE(sentence));
+      }
     }
     return responses;
   }
@@ -250,8 +242,8 @@ class CENode {
     this.lastInstanceId = this.instances.length;
     this.lastConceptId = this.concepts.length;
     this.lastCardId = 0;
-    for (let i = 0; i < models.length; i += 1) {
+    for (const model of models) {
-      this.loadModel(models[i]);
+      this.loadModel(model);
     }
   }
 }

src/CEParser.js

@@ -30,6 +30,14 @@ const quotes = {
 
 class CEParser {
 
+  static error(message, concerns) {
+    return { error: true, response: { message, type: 'gist', concerns } };
+  }
+
+  static success(message, concerns) {
+    return { error: false, response: { message, type: 'gist', concerns } };
+  }
+
   /*
    * Submit CE to be processed by node.
    * This may result in
@@ -42,17 +50,22 @@ class CEParser {
    * Returns: [bool, str] (bool = success, str = error or parsed string)
    */
   parse(input, source) {
-    const t = input.replace(/\s+/g, ' ').replace(/\.+$/, '').trim(); // Whitespace -> single space
+    try {
+      // Whitespace -> single space:
+      const t = input.replace(/\s+/g, ' ').replace(/\.+$/, '').trim();
       if (t.match(/^conceptualise an?/i)) {
         return this.newConcept(t, source);
-    } else if (t.match(/^conceptualise the/i)) {
+      } else if (t.match(/^conceptualise the ([a-zA-Z0-9 ]*) ([A-Z0-9]+) (?:has|is|~)/i)) {
         return this.modifyConcept(t, source);
       } else if (t.match(/^there is an? ([a-zA-Z0-9 ]*) named/i)) {
         return this.newInstance(t, source);
       } else if (t.match(/^the ([a-zA-Z0-9 ]*)/i)) {
         return this.modifyInstance(t, source);
       }
-    return [false, null];
+      return CEParser.error('Input not a valid CE sentence.');
+    } catch (err) {
+      return CEParser.error(`There was a problem parsing the CE. ${err}.`);
+    }
   }
 
   newConcept(t, source) {
@@ -61,7 +74,7 @@ class CEParser {
     const storedConcept = this.node.getConceptByName(conceptName);
     let concept = null;
     if (storedConcept) {
-      return [false, 'This concept already exists.'];
+      return CEParser.error('This concept already exists');
     }
     concept = new CEConcept(this.node, conceptName, source);
 
@@ -70,16 +83,19 @@ class CEParser {
     for (const fact of facts) {
       this.processConceptFact(concept, fact, source);
     }
-    return [true, t, concept];
+    return CEParser.success(t, concept);
   }
 
   modifyConcept(t, source) {
     const conceptInfo = t.match(/^conceptualise the ([a-zA-Z0-9 ]*) ([A-Z0-9]+) (?:has|is|~)/);
+    if (!conceptInfo) {
+      return CEParser.error('Unable to parse sentence');
+    }
     const conceptName = conceptInfo[1];
     const conceptVar = conceptInfo[2];
     const concept = this.node.getConceptByName(conceptName);
     if (!concept) {
-      return [false, `Concept ${conceptInfo[1]} not known.`];
+      return CEParser.error(`Concept ${conceptInfo[1]} not known.`);
     }
 
     const remainderRegex = new RegExp(`^conceptualise the ${conceptName} ${conceptVar}`, 'i');
@@ -88,7 +104,7 @@ class CEParser {
     for (const fact of facts) {
       this.processConceptFact(concept, fact, source);
     }
-    return [true, t, concept];
+    return CEParser.success(t, concept);
   }
 
   processConceptFact(concept, fact, source) {
@@ -132,19 +148,19 @@ class CEParser {
     let names = t.match(/^there is an? ([a-zA-Z0-9 ]*) named '([^'\\]*(?:\\.[^'\\]*)*)'/i);
     if (!names) {
       names = t.match(/^there is an? ([a-zA-Z0-9 ]*) named ([a-zA-Z0-9_]*)/i);
-      if (!names) { return [false, 'Unable to determine name of instance.']; }
+      if (!names) { return CEParser.error('Unable to determine name of instance.'); }
     }
     const conceptName = names[1];
     const instanceName = names[2].replace(/\\/g, '');
     const concept = this.node.getConceptByName(conceptName);
-    const currentInstance = this.node.getInstanceByName(instanceName);
+    const currentInstance = this.node.getInstanceByName(instanceName, concept);
-    const instance = new CEInstance(this.node, concept, instanceName, source);
     if (!concept) {
-      return [false, `Instance type unknown: ${conceptName}`];
+      return CEParser.error(`Instance type unknown: ${conceptName}`);
     }
     if (currentInstance && currentInstance.type.id === concept.id) {
-      return [true, 'There is already an instance of this type with this name.', currentInstance];
+      return CEParser.error('There is already an instance of this type with this name.', currentInstance);
     }
+    const instance = new CEInstance(this.node, concept, instanceName, source);
     instance.sentences.push(t);
 
     const remainder = t.replace(/^there is an? (?:[a-zA-Z0-9 ]*) named (?:[a-zA-Z0-9_]*|'[a-zA-Z0-9_ ]*') that/, '');
@@ -152,42 +168,47 @@ class CEParser {
     for (const fact of facts) {
       this.processInstanceFact(instance, fact, source);
     }
-    return [true, t, instance];
+    return CEParser.success(t, instance);
   }
 
   modifyInstance(t, source) {
     let concept;
     let instance;
-    if (t.match(/^the ([a-zA-Z0-9 ]*) '([^'\\]*(?:\\.[^'\\]*)*)'/i)) {
+    let instanceName;
-      const names = t.match(/^the ([a-zA-Z0-9 ]*) '([^'\\]*(?:\\.[^'\\]*)*)'/i);
+    if (t.match(/^the ([a-zA-Z0-9 ]*)/i)) {
-      if (names) {
-        concept = this.node.getConceptByName(names[1]);
-        instance = this.node.getInstanceByName(names[2].replace(/\\/g, ''));
-      }
-    }
-    if (!instance && t.match(/^the ([a-zA-Z0-9 ]*)/i)) {
       const names = t.match(/^the ([a-zA-Z0-9 ]*)/i);
       const nameTokens = names[1].split(' ');
-      for (let i = 0; i < this.node.concepts.length; i += 1) {
+      for (const conceptCheck of this.node.concepts) {
-        if (names[1].toLowerCase().indexOf(this.node.concepts[i].name.toLowerCase()) === 0) {
+        if (names[1].toLowerCase().indexOf(conceptCheck.name.toLowerCase()) === 0) {
-          concept = this.node.concepts[i];
+          concept = conceptCheck;
-          const instanceName = nameTokens[concept.name.split(' ').length].toLowerCase();
+          instanceName = nameTokens[concept.name.split(' ').length];
-          instance = concept[instanceName];
+          instance = this.node.getInstanceByName(instanceName, concept);
           break;
         }
       }
     }
+    if (!instance && t.match(/^the ([a-zA-Z0-9 ]*) '([^'\\]*(?:\\.[^'\\]*)*)'/i)) {
+      const names = t.match(/^the ([a-zA-Z0-9 ]*) '([^'\\]*(?:\\.[^'\\]*)*)'/i);
+      if (names) {
+        concept = this.node.getConceptByName(names[1]);
+        instanceName = names[2].replace(/\\/g, '');
+        instance = this.node.getInstanceByName(instanceName, concept);
+      }
+    }
     if (!concept || !instance) {
-      return [false, `Unknown concept/instance combination in: ${t}`];
+      return CEParser.error(`Unknown concept/instance combination in: ${t}`);
     }
     instance.sentences.push(t);
-
+    const tokens = t.split(' ');
-    const remainder = t.replace(`'${instance.name}'`, instance.name).replace(`the ${concept.name} ${instance.name}`.trim(), '');
+    tokens.splice(0, 1 + concept.name.split(' ').length + instanceName.split(' ').length);
+    const remainder = tokens.join(' ');
     const facts = remainder.replace(/\band\b/g, '+').match(/(?:'(?:\\.|[^'])*'|[^+])+/g);
+    if (facts) {
       for (const fact of facts) {
         this.processInstanceFact(instance, fact, source);
       }
-    return [true, t, instance];
+    }
+    return CEParser.success(t, instance);
   }
 
   processInstanceFact(instance, fact, source) {
@@ -199,12 +220,15 @@ class CEParser {
       const relConceptName = match[2];
       const relInstanceName = match[3].replace(/'/g, '');
       const relConcept = this.node.getConceptByName(relConceptName);
-      let relInstance = this.node.getInstanceByName(relInstanceName);
+
+      if (relConcept) {
+        let relInstance = this.node.getInstanceByName(relInstanceName, relConcept);
         if (!relInstance) {
           relInstance = new CEInstance(this.node, relConcept, relInstanceName, source);
         }
         instance.addRelationship(label, relInstance, true, source);
       }
+    }
     if (input.match(/^has ([a-zA-Z0-9]*|'[^'\\]*(?:\\.[^'\\]*)*') as ([a-zA-Z0-9 ]*)/)) {
       const re = /^has ([a-zA-Z0-9]*|'[^'\\]*(?:\\.[^'\\]*)*') as ([a-zA-Z0-9 ]*)/;
       const match = re.exec(input);
@@ -219,12 +243,14 @@ class CEParser {
       const valInstanceName = match[2].replace(/'/g, '');
       const label = match[3];
       const valConcept = this.node.getConceptByName(valConceptName);
-      let valInstance = this.node.getInstanceByName(valInstanceName);
+      if (valConcept) {
+        let valInstance = this.node.getInstanceByName(valInstanceName, valConcept);
         if (!valInstance) {
           valInstance = new CEInstance(this.node, valConcept, valInstanceName, source);
         }
         instance.addValue(label, valInstance, true, source);
       }
+    }
     if (input.match(/(?:is| )?an? ([a-zA-Z0-9 ]*)/g)) {
       const re = /(?:is| )?an? ([a-zA-Z0-9 ]*)/g;
       const match = re.exec(input);

src/CEServer.js

@@ -20,44 +20,191 @@ const http = require('http');
 const CENode = require('./CENode.js');
 const CEModels = require('../models/index.js');
 
-const POST_SENTENCES_ENDPOINT = '/sentences';
+class CEServer {
-const GET_CARDS_ENDPOINT = '/cards';
 
-function postSentences(node, request, response) {
+  constructor(name, port, models) {
+    this.port = port;
+    this.node = new CENode();
+    if (models) {
+      for (const model of models) {
+        this.node.loadModel(CEModels[model]);
+      }
+    }
+    this.node.attachAgent();
+    this.node.agent.setName(name);
+    this.handlers = {
+      GET: {
+        '/cards': (request, response) => {
+          const agentRegex = decodeURIComponent(request.url).match(/agent=(.*)/);
+          const agentStr = agentRegex ? agentRegex[1] : null;
+          const agents = (agentStr && agentStr.toLowerCase().split(',')) || [];
+          let s = '';
+          for (const card of this.node.getInstances('card', true)) {
+            for (const to of card.is_tos) {
+              for (const agent of agents) {
+                if (to.name.toLowerCase() === agent) {
+                  s += `${card.ce}\n`;
+                  break;
+                }
+              }
+            }
+          }
+          response.writeHead(200, { 'Content-Type': 'text/ce' });
+          response.end(s);
+        },
+        '/concepts': (request, response) => {
+          const concepts = [];
+          for (const concept of this.node.concepts) {
+            concepts.push({
+              name: concept.name,
+              id: concept.id,
+            });
+          }
+          response.writeHead(200, { 'Content-Type': 'application/json' });
+          response.end(JSON.stringify(concepts));
+        },
+        '/concept': (request, response) => {
+          const idRegex = decodeURIComponent(request.url).match(/id=(.*)/);
+          const id = idRegex ? idRegex[1] : null;
+          const concept = this.node.getConceptById(id);
+          if (concept) {
+            const body = { name: concept.name, ce: concept.ce, parents: [], children: [], instances: [], values: [], relationships: [] };
+            for (const parent of concept.parents) {
+              body.parents.push({
+                name: parent.name,
+                id: parent.id,
+              });
+            }
+            for (const child of concept.children) {
+              body.children.push({
+                name: child.name,
+                id: child.id,
+              });
+            }
+            for (const instance of concept.instances) {
+              body.instances.push({
+                name: instance.name,
+                id: instance.id,
+              });
+            }
+            for (const value of concept.values) {
+              const valueName = value.concept && value.concept.name;
+              const valueId = value.concept && value.concept.id;
+              body.values.push({ label: value.label, targetName: valueName, targetId: valueId });
+            }
+            for (const relationship of concept.relationships) {
+              body.relationships.push({ label: relationship.label, targetName: relationship.concept.name, targetId: relationship.concept.id });
+            }
+            response.writeHead(200, { 'Content-Type': 'application/json' });
+            return response.end(JSON.stringify(body));
+          }
+          response.writeHead(404);
+          return response.end('Concept not found');
+        },
+        '/instances': (request, response) => {
+          const instances = [];
+          for (const instance of this.node.instances) {
+            instances.push({
+              name: instance.name,
+              id: instance.id,
+              conceptName: instance.concept.name,
+              conceptId: instance.concept.id,
+            });
+          }
+          response.writeHead(200, { 'Content-Type': 'application/json' });
+          response.end(JSON.stringify(instances));
+        },
+        '/instance': (request, response) => {
+          const idRegex = decodeURIComponent(request.url).match(/id=(.*)/);
+          const nameRegex = decodeURIComponent(request.url).match(/name=(.*)/);
+          const idQuery = idRegex ? idRegex[1] : null;
+          const nameQuery = nameRegex ? nameRegex[1] : null;
+          let instance;
+          if (idQuery) {
+            instance = this.node.getInstanceById(idQuery);
+          } else if (nameQuery) {
+            instance = this.node.getInstanceByName(nameQuery);
+          }
+          if (instance) {
+            const body = {
+              name: instance.name,
+              conceptName: instance.concept.name,
+              conceptId: instance.concept.id,
+              ce: instance.ce,
+              gist: instance.gist,
+              synonyms: instance.synonyms,
+              subConcepts: [],
+              values: [],
+              relationships: [],
+            };
+            for (const concept of instance.subConcepts) {
+              body.subConcepts.push({ name: concept.name, id: concept.id });
+            }
+            for (const value of instance.values) {
+              const valueName = value.instance.name || value.instance;
+              const valueId = value.instance.id;
+              const conceptName = value.instance.concept && value.instance.concept.name;
+              const conceptId = value.instance.concept && value.instance.concept.id;
+              body.values.push({ label: value.label, targetName: valueName, targetId: valueId, targetConceptName: conceptName, targetConceptId: conceptId });
+            }
+            for (const relationship of instance.relationships) {
+              body.relationships.push({ label: relationship.label, targetName: relationship.instance.name, targetId: relationship.instance.id, targetConceptName: relationship.instance.concept.name, targetConceptId: relationship.instance.concept.id });
+            }
+            response.writeHead(200, { 'Content-Type': 'application/json' });
+            return response.end(JSON.stringify(body));
+          }
+          response.writeHead(404);
+          return response.end('Unable to find the instance.');
+        },
+        '/info': (request, response) => {
+          const body = { recentInstances: [], recentConcepts: [], instanceCount: this.node.instances.length, conceptCount: this.node.concepts.length };
+          const recentInstances = this.node.instances.slice(this.node.instances.length >= 10 ? this.node.instances.length - 10 : 0);
+          for (const instance of recentInstances) {
+            body.recentInstances.push({
+              name: instance.name,
+              id: instance.id,
+              conceptName: instance.concept.name,
+              conceptId: instance.concept.id,
+            });
+          }
+          for (const concept of this.node.concepts) {
+            body.recentConcepts.push({
+              name: concept.name,
+              id: concept.id,
+            });
+          }
+          response.writeHead(200, { 'Content-Type': 'application/json' });
+          response.end(JSON.stringify(body));
+        },
+        '/model': (request, response) => {
+          let body = '';
+          for (const concept of this.node.concepts) { body += `${concept.creationCE}\n`; }
+          for (const concept of this.node.concepts) { body += `${concept.getCE(true)}\n`; }
+          for (const instance of this.node.instances) { body += `${instance.creationCE}\n`; }
+          for (const instance of this.node.instances) { body += `${instance.getCE(true)}\n`; }
+          response.writeHead(200, { 'Content-Type': 'text/ce', 'Content-Disposition': `attachment; filename="${this.node.agent.name}.ce"` });
+          response.end(body);
+        },
+      },
+      POST: {
+        '/cards': (request, response) => {
           let body = '';
           request.on('data', (chunk) => { body += chunk; });
           request.on('end', () => {
-    body = decodeURIComponent(body.replace('sentence=', '').replace(/\+/g, ' '));
+            const ignores = body.split(/\\n|\n/);
-    const sentences = body.split(/\\n|\n/);
+            const agentRegex = decodeURIComponent(request.url).match(/agent=(.*)/);
-    const responses = node.addSentences(sentences);
+            const agentStr = agentRegex ? agentRegex[1] : null;
-    response.write(responses.map(resp => resp.data).join('\n'));
+            const agents = (agentStr && agentStr.toLowerCase().split(',')) || [];
-    response.end();
-  });
-}
-
-function getCards(node, request, response, ignoresInput) {
-  const url = decodeURIComponent(request.url);
-  const agentRegex = url.match(/agent=(.*)/);
-  const ignores = ignoresInput || [];
-  let agentStr = null;
-  let agents = [];
-  if (agentRegex) { agentStr = agentRegex[1]; }
-  if (agentStr) {
-    agents = agentStr.toLowerCase().split(',');
-  }
-  const cards = node.getInstances('card', true);
             let s = '';
-  for (let i = 0; i < cards.length; i += 1) {
+            for (const card of this.node.getInstances('card', true)) {
-    if (ignores.indexOf(cards[i].name) === -1) {
+              if (ignores.indexOf(card.name) === -1) {
-      if (!agents || agents.length === 0) {
+                if (agents.length === 0) {
-        s += `${cards[i].ce}\n`;
+                  s += `${card.ce}\n`;
-      } else {
+                } else if (card.is_tos) {
-        const tos = cards[i].is_tos;
+                  for (const to of card.is_tos) {
-        if (tos) {
+                    for (const agent of agents) {
-          for (let j = 0; j < tos.length; j += 1) {
+                      if (to.name.toLowerCase() === agent) {
-            for (let k = 0; k < agents.length; k += 1) {
+                        s += `${card.ce}\n`;
-              if (tos[j].name.toLowerCase() === agents[k]) {
-                s += `${cards[i].ce}\n`;
                         break;
                       }
                     }
@@ -65,96 +212,85 @@ function getCards(node, request, response, ignoresInput) {
                 }
               }
             }
-  }
-  response.write(s);
-  response.end();
-}
-
-function startServer() {
-  const node = new CENode(CEModels.core, CEModels.server);
-  node.attachAgent();
-  let port = 5555;
-  if (process.argv.length > 3) {
-    port = process.argv[3];
-  }
-  if (process.argv.length > 2) {
-    node.agent.setName(process.argv[2]);
-  }
-
-  http.createServer((request, response) => {
-    response.setHeader('Access-Control-Allow-Origin', '*');
-
-    if (request.method === 'GET') {
-      if (request.url === '/') {
-        const ins = node.instances;
-        const con = node.concepts;
-        let s = '<html><head><title>CENode Management</title></head><body><h1>CENode Server Admin Interface</h1>';
-        s += '<div style="width:48%;float:left;"><h2>Conceptual model</h2>';
-        s += '<p>Add CE sentences to the node:</p><form action="/ui/sentences" enctype="application/x-www-form-urlencoded" method="POST"><textarea name="sentence" style="width:95%;height:100px;"></textarea><br /><br /><input type="submit" /></form></div>';
-        s += `<div style="width:48%;float:left;"><h2>Node settings</h2><p>Update local agent name:</p><form method="POST" action="/agent-name"><input type="text" name="name" value="${node.agent.name}" /><input type="submit" /></form>`;
-        s += '<p>Other options:</p><button onclick="window.location=\'/reset\';">Empty model</button>';
-        s += '</div><div style="clear:both;"></div>';
-        s += '<div style="display:inline-block;width:45%;float:left;"><h2>Concepts</h2>';
-        for (const concept of con) {
-          s += concept.name;
-          if (concept.parents.length) {
-            s += ` (${concept.parents[0].name})`;
-          }
-          s += '<br>';
-        }
-        s += '</div><div style="display:inline-block;width:45%;float:right;"><h2>Instances</h2>';
-        for (const instance of ins) {
-          s += `${instance.name} (${instance.type.name})<br>`;
-        }
-        s += '</div><body></html>';
-        response.writeHead(200, { 'Content-Type': 'text/html' });
-        response.end(s);
-      } else if (request.url.indexOf(GET_CARDS_ENDPOINT) === 0) {
             response.writeHead(200, { 'Content-Type': 'text/ce' });
-        getCards(node, request, response);
+            response.end(s);
-      } else if (request.url === '/reset') {
+          });
-        node.resetAll();
+        },
-        response.writeHead(302, { Location: '/' });
+        '/sentences': (request, response) => {
-        response.end();
-      } else {
-        response.writeHead(404);
-        response.end('404: Resource not found for method GET.');
-      }
-    } else if (request.method === 'POST') {
-      if (request.url.indexOf(GET_CARDS_ENDPOINT) === 0) {
           let body = '';
           request.on('data', (chunk) => { body += chunk; });
           request.on('end', () => {
-          const ignores = body.split(/\\n|\n/);
+            body = decodeURIComponent(body.replace('sentence=', '').replace(/\+/g, ' '));
+            const sentences = body.split(/\\n|\n/);
+            const responses = this.node.addSentences(sentences);
             response.writeHead(200, { 'Content-Type': 'text/ce' });
-          getCards(node, request, response, ignores);
+            response.end(responses.map(resp => resp.data).join('\n'));
           });
-      } else if (request.url === POST_SENTENCES_ENDPOINT) {
+        },
-        response.writeHead(200, { 'Content-Type': 'text/ce' });
+      },
-        postSentences(node, request, response);
+      PUT: {
-      } else if (request.url === '/ui/sentences') {
+        '/reset': (request, response) => {
-        response.writeHead(302, { Location: '/' });
+          this.node.resetAll();
-        postSentences(node, request, response);
+          response.writeHead(204);
-      } else if (request.url === '/agent-name') {
+          response.end();
+        },
+        '/agent/name': (request, response) => {
           let body = '';
           request.on('data', (chunk) => { body += chunk; });
           request.on('end', () => {
             body = decodeURIComponent(body.replace('name=', '').replace(/\+/g, ' '));
-          node.agent.setName(body);
+            this.node.agent.setName(body);
             response.writeHead(302, { Location: '/' });
             response.end();
           });
+        },
+      },
+    };
+  }
+
+  start() {
+    this.server = http.createServer((request, response) => {
+      response.setHeader('Access-Control-Allow-Origin', '*');
+      if (request.method in this.handlers) {
+        const path = request.url.indexOf('?') > 1 ? request.url.slice(0, request.url.indexOf('?')) : request.url;
+        if (path in this.handlers[request.method]) {
+          try {
+            this.handlers[request.method][path](request, response);
+          } catch (err) {
+            response.writeHead(500);
+            response.end(`500: ${err}.`);
+          }
         } else {
           response.writeHead(404);
-        response.end('404: Resource not found for method POST.');
+          response.end(`404: Resource not found for method ${request.method}.`);
         }
+      } else if (request.method === 'OPTIONS') {
+        response.setHeader('Access-Control-Allow-Headers', 'X-Requested-With, Content-Type');
+        response.setHeader('Access-Control-Allow-Methods', 'GET, POST, PUT, DELETE');
+        response.writeHead(200);
+        response.end();
       } else {
         response.writeHead(405);
         response.end('405: Method not allowed on this server.');
       }
-  }).listen(port || 5555);
+    });
+    this.server.listen(this.port);
+    this.server.on('error', () => { this.node = undefined; });
+  }
+
+  stop() {
+    if (this.server) {
+      delete this.node;
+      this.server.close();
+    }
+  }
 }
 
 if (require.main === module) {
-  startServer();
+  const name = process.argv.length > 2 ? process.argv[2] : 'Moira';
+  const port = process.argv.length > 3 ? process.argv[3] : 5555;
+  const models = process.argv.slice(4);
+  new CEServer(name, port, models).start();
 }
+
+module.exports = CEServer;

src/CardHandler.js

@@ -38,9 +38,9 @@ class CardHandler {
           // Prepare the response 'tell card' and add this back to the node
           let urls;
           let c;
-          if (data.data) {
+          if (data.response.message) {
-            urls = data.data.match(/(https?:\/\/[a-zA-Z0-9./\-+_&=?!%]*)/gi);
+            urls = data.response.message.match(/(https?:\/\/[a-zA-Z0-9./\-+_&=?!%]*)/gi);
-            c = `there is a ${data.type} card named 'msg_{uid}' that is from the agent '${this.agent.name.replace(/'/g, "\\'")}' and has the timestamp '{now}' as timestamp and has '${data.data.replace(/'/g, "\\'")}' as content`;
+            c = `there is a ${data.response.type} card named 'msg_{uid}' that is from the agent '${this.agent.name.replace(/'/g, "\\'")}' and has the timestamp '{now}' as timestamp and has '${data.response.message.replace(/'/g, "\\'")}' as content`;
           } else {
             c = `there is a gist card named 'msg_{uid}' that is from the agent '${this.agent.name.replace(/'/g, "\\'")}' and has the timestamp '{now}' as timestamp and has 'Sorry; your question was not understood.' as content`;
           }
@@ -63,12 +63,12 @@ class CardHandler {
         // Add the CE sentence to the node
         const data = this.node.addCE(card.content, card.is_from && card.is_from.name);
 
-        if (!data.success && card.is_from) {
+        if (data.error && card.is_from) {
           // If unsuccessful, write an error back
           return this.node.addSentence(`there is a gist card named 'msg_{uid}' that is from the agent '${this.agent.name.replace(/'/g, "\\'")}' and is to the ${card.is_from.type.name} '${card.is_from.name.replace(/'/g, "\\'")}' and has the timestamp '{now}' as timestamp and has 'Sorry. Your input was not understood.' as content and is in reply to the card '${card.name}'.`);
         }
 
-        if (data.success === true) {
+        if (!data.error) {
           // Add sentence to any active tell policy queues
           for (const policy of this.node.getInstances('tell policy')) {
             if (policy.enabled === 'true' && policy.target && policy.target.name) {
@@ -86,12 +86,12 @@ class CardHandler {
               const ack = policy.acknowledgement;
               if (policy.target.name.toLowerCase() === card.is_from.name.toLowerCase()) {
                 let c;
-                if (ack === 'basic') { c = 'OK.'; } else if (data.type === 'tell') {
+                if (ack === 'basic') { c = 'OK.'; } else if (data.response.type === 'tell') {
-                  c = `OK. I added this to my knowledge base: ${data.data}`;
+                  c = `OK. I added this to my knowledge base: ${data.response.message}`;
-                } else if (data.type === 'ask' || data.type === 'confirm' || data.type === 'gist') {
+                } else if (data.response.type === 'ask' || data.response.type === 'confirm' || data.response.type === 'gist') {
-                  c = data.data;
+                  c = data.response.message;
                 }
-                return this.node.addSentence(`there is a ${data.type} card named 'msg_{uid}' that is from the agent '${this.agent.name.replace(/'/g, "\\'")}' and is to the ${card.is_from.type.name} '${card.is_from.name.replace(/'/g, "\\'")}' and has the timestamp '{now}' as timestamp and has '${c.replace(/'/g, "\\'")}' as content and is in reply to the card '${card.name}'.`);
+                return this.node.addSentence(`there is a ${data.response.type} card named 'msg_{uid}' that is from the agent '${this.agent.name.replace(/'/g, "\\'")}' and is to the ${card.is_from.type.name} '${card.is_from.name.replace(/'/g, "\\'")}' and has the timestamp '{now}' as timestamp and has '${c.replace(/'/g, "\\'")}' as content and is in reply to the card '${card.name}'.`);
               }
             }
           }
@@ -102,23 +102,34 @@ class CardHandler {
       'nl card': (card) => {
         let data = this.node.addCE(card.content, card.is_from && card.is_from.name);
         // If valid CE, then replicate the nl card as a tell card ('autoconfirm')
-        if (data.success) {
+        if (!data.error) {
           return this.node.addSentence(`there is a tell card named 'msg_{uid}' that is from the ${card.is_from.type.name} '${card.is_from.name.replace(/'/g, "\\'")}' and is to the agent '${this.agent.name.replace(/'/g, "\\'")}' and has the timestamp '{now}' as timestamp and has '${card.content.replace(/'/g, "\\'")}' as content.`);
         }
         data = this.node.askQuestion(card.content);
         // If question was success replicate as ask card ('autoask')
-        if (data.success) {
+        if (!data.error) {
           return this.node.addSentence(`there is an ask card named 'msg_{uid}' that is from the ${card.is_from.type.name} '${card.is_from.name.replace(/'/g, "\\'")}' and is to the agent '${this.agent.name.replace(/'/g, "\\'")}' and has the timestamp '{now}' as timestamp and has '${card.content.replace(/'/g, "\\'")}' as content.`);
         }
         // If question not understood then place the response to the NL card in a new response
         data = this.node.addNL(card.content);
-        return this.node.addSentence(`there is a ${data.type} card named 'msg_{uid}' that is from the agent '${this.agent.name.replace(/'/g, "\\'")}' and is to the ${card.is_from.type.name} '${card.is_from.name.replace(/'/g, "\\'")}' and has the timestamp '{now}' as timestamp and has '${data.data.replace(/'/g, "\\'")}' as content and is in reply to the card '${card.name}'.`);
+        return this.node.addSentence(`there is a ${data.response.type} card named 'msg_{uid}' that is from the agent '${this.agent.name.replace(/'/g, "\\'")}' and is to the ${card.is_from.type.name} '${card.is_from.name.replace(/'/g, "\\'")}' and has the timestamp '{now}' as timestamp and has '${data.response.message.replace(/'/g, "\\'")}' as content and is in reply to the card '${card.name}'.`);
+      },
+
+      'gist card': (card) => {
+        // Add sentence to any active gist policy queues
+        for (const policy of this.node.getInstances('gist policy')) {
+          if (policy.enabled === 'true' && policy.target && policy.target.name) {
+            const targetName = policy.target.name;
+            if (!(targetName in this.agent.policyHandler.unsentGistCards)) { this.agent.policyHandler.unsentGistCards[targetName] = []; }
+            this.agent.policyHandler.unsentGistCards[targetName].push(card);
+          }
+        }
       },
     };
   }
 
   handle(card) {
-    if (card.is_tos && card.content && this.agent.handledCards.indexOf(card.name) === -1) {
+    if (card.type.name in this.handlers && card.is_tos && card.content && this.agent.handledCards.indexOf(card.name) === -1) {
       // Determine whether or not to read or ignore this card:
       for (const to of card.is_tos) {
         if (to.name.toLowerCase() === this.agent.name.toLowerCase()) {

src/NLParser.js

@@ -18,6 +18,14 @@
 
 class NLParser {
 
+  static error(message) {
+    return { error: true, response: { message, type: 'gist' } };
+  }
+
+  static success(message) {
+    return { error: false, response: { message, type: 'confirm' } };
+  }
+
   /*
    * Submit natural language to be processed by node.
    * This results in
@@ -122,7 +130,7 @@ class NLParser {
         }
       }
       if (facts.length > 0) {
-        return [true, ce + facts.join(' and ')];
+        return NLParser.success(ce + facts.join(' and '));
       }
     }
 
@@ -140,12 +148,12 @@ class NLParser {
           }
         }
         if (newInstanceName && newInstanceName.length) {
-          return [true, `there is a ${this.node.concepts[i].name} named '${newInstanceName.trim()}'`];
+          return NLParser.success(`there is a ${this.node.concepts[i].name} named '${newInstanceName.trim()}'`);
         }
-        return [true, `there is a ${this.node.concepts[i].name} named '${this.node.concepts[i].name} ${this.node.instances.length}${1}'`];
+        return NLParser.success(`there is a ${this.node.concepts[i].name} named '${this.node.concepts[i].name} ${this.node.instances.length}${1}'`);
       }
     }
-    return [false, `Un-parseable input: ${t}`];
+    return NLParser.error(`Un-parseable input: ${t}`);
   }
 
   /*

src/PolicyHandler.js

@@ -84,8 +84,9 @@ class PolicyHandler {
   constructor(agent) {
     this.agent = agent;
     this.node = agent.node;
-    this.unsentTellCards = [];
+    this.unsentTellCards = {};
-    this.unsentAskCards = [];
+    this.unsentAskCards = {};
+    this.unsentGistCards = {};
     this.lastSuccessfulRequest = 0;
     this.handlers = {
 
@@ -93,6 +94,9 @@ class PolicyHandler {
         // For each tell policy in place, send all currently-untold cards to each target
         // multiple cards to be sent to one target line-separated
         if (policy.target && policy.target.name && policy.target.address) {
+          if (!(policy.target.name in this.unsentTellCards)) {
+            this.unsentTellCards[policy.target.name] = [];
+          }
           let data = '';
           for (const card of this.unsentTellCards[policy.target.name]) {
             if (card.is_tos && card.is_from.name.toLowerCase() !== policy.target.name.toLowerCase()) { // Don't send back a card sent from target agent
@@ -120,6 +124,9 @@ class PolicyHandler {
         // For each ask policy in place send all currently-untold cards to each target
         // multiple cards to be sent to one target are line-separated
         if (policy.target && policy.target.name) {
+          if (!(policy.target.name in this.unsentAskCards)) {
+            this.unsentAskCards[policy.target.name] = [];
+          }
           let data = '';
           for (const card of this.unsentAskCards[policy.target.name]) {
             const froms = card.is_froms;
@@ -153,6 +160,36 @@ class PolicyHandler {
         }
       },
 
+      'gist policy': (policy) => {
+        // For each gist policy in place, send all currently-untold cards to each target
+        // multiple cards to be sent to one target line-separated
+        if (policy.target && policy.target.name && policy.target.address) {
+          if (!(policy.target.name in this.unsentGistCards)) {
+            this.unsentGistCards[policy.target.name] = [];
+          }
+          let data = '';
+          for (const card of this.unsentGistCards[policy.target.name]) {
+            if (card.is_tos && card.is_from.name.toLowerCase() !== policy.target.name.toLowerCase()) { // Don't send back a card sent from target agent
+              // Make sure target is not already a recipient
+              let inCard = false;
+              for (const to of card.is_tos) {
+                if (to.id === policy.target.id) { inCard = true; break; }
+              }
+              if (!inCard) {
+                card.addRelationship('is to', policy.target);
+              }
+              data += `${card.ce}\n`;
+            }
+          }
+          if (data.length) {
+            net.makeRequest('POST', policy.target.address, POST_SENTENCES_ENDPOINT, data, () => {
+              this.lastSuccessfulRequest = new Date().getTime();
+              this.unsentGistCards[policy.target.name] = [];
+            });
+          }
+        }
+      },
+
       'listen policy': (policy) => {
         // Make request to target to get cards addressed to THIS agent
         if (policy.target && policy.target.address) {
@@ -175,11 +212,12 @@ class PolicyHandler {
         if (policy.start_time) {
           const startTime = policy.start_time;
           for (const card of cards) {
+            if (card.timestamp && card.is_froms.length) {
               let toAgent = false;
               const tos = card.is_tos;
               const from = card.is_froms[0];
               const cardTimestamp = card.timestamp.name;
-            if (tos && parseInt(cardTimestamp, 10) > parseInt(startTime, 10)) {
+              if (tos && parseInt(cardTimestamp, 10) > parseInt(startTime.name, 10)) {
                 for (const to of tos) {
                   if (to.name === this.agent.name) { // If card sent to THIS agent
                     toAgent = true;
@@ -204,12 +242,13 @@ class PolicyHandler {
               }
             }
           }
+        }
       },
     };
   }
 
   handle(policy) {
-    if (policy.enabled === 'true') {
+    if (policy.enabled === 'true' && policy.type.name in this.handlers) {
       this.handlers[policy.type.name](policy);
     }
   }

src/QuestionParser.js

@@ -18,6 +18,14 @@
 
 class QuestionParser {
 
+  static error(message) {
+    return { error: true, response: { message, type: 'gist' } };
+  }
+
+  static success(message) {
+    return { error: false, response: { message, type: 'gist' } };
+  }
+
   /*
    * Submit a who/what/where question to be processed by node.
    * This may result in
@@ -28,6 +36,7 @@ class QuestionParser {
    * Returns: [bool, str] (bool = success, str = error or response)
    */
   parse(t) {
+    try {
       const input = t.trim();
       if (t.match(/^where (is|are)/i)) {
         return this.whereIs(input);
@@ -42,7 +51,10 @@ class QuestionParser {
       } else if (t.match(/^list (\ball\b|\binstances\b)/i)) {
         return this.listInstances(input);
       }
-    return [false, null];
+      return QuestionParser.error('Input is not a valid question');
+    } catch (err) {
+      return QuestionParser.error(`There was a problem with the question. ${err}.`);
+    }
   }
 
   whereIs(t) {
@@ -50,8 +62,7 @@ class QuestionParser {
     const instance = this.node.getInstanceByName(thing);
     let message;
     if (!instance) {
-      message = `I don't know what ${thing} is.`;
+      return QuestionParser.success(`I don't know what ${thing} is.`);
-      return [true, message];
     }
     const locatableInstances = this.node.getInstances('location', true);
     const locatableIds = [];
@@ -80,8 +91,7 @@ class QuestionParser {
       }
     }
     if (!placeFound) {
-      message = `I don't know where ${instance.name} is.`;
+      return QuestionParser.success(`I don't know where ${instance.name} is.`);
-      return [true, message];
     }
     message = instance.name;
     for (const place in places) {
@@ -93,7 +103,7 @@ class QuestionParser {
         message += ' and';
       }
     }
-    return [true, `${message.substring(0, message.length - 4)}.`];
+    return QuestionParser.success(`${message.substring(0, message.length - 4)}.`);
   }
 
   whatIsIn(t) {
@@ -106,7 +116,7 @@ class QuestionParser {
       }
     }
     if (!instance) {
-      return [true, `${thing} is not an instance of type location.`];
+      return QuestionParser.success(`${thing} is not an instance of type location.`);
     }
     const things = {};
     let thingFound = false;
@@ -133,7 +143,7 @@ class QuestionParser {
       }
     }
     if (!thingFound) {
-      return [true, `I don't know what is located in/on/at the ${instance.type.name} ${instance.name}.`];
+      return QuestionParser.success(`I don't know what is located in/on/at the ${instance.type.name} ${instance.name}.`);
     }
 
     let message = '';
@@ -144,7 +154,7 @@ class QuestionParser {
       }
       message += ' and';
     }
-    return [true, `${message.substring(0, message.length - 4)}.`];
+    return QuestionParser.success(`${message.substring(0, message.length - 4)}.`);
   }
 
   whatIs(input) {
@@ -156,7 +166,7 @@ class QuestionParser {
     if (name) {
       instance = this.node.getInstanceByName(name[2]);
       if (instance) {
-        return [true, instance.gist];
+        return QuestionParser.success(instance.gist);
       }
     }
 
@@ -187,13 +197,14 @@ class QuestionParser {
           }
         }
         if (possibilities.length > 0) {
-          return [true, `'${name}' ${possibilities.join(' and ')}.`];
+          return QuestionParser.success(`'${name}' ${possibilities.join(' and ')}.`);
         }
 
         // If nothing found, do fuzzy search
         const searchReturn = this.fuzzySearch(t);
         let fuzzyGist = 'I know about ';
         let fuzzyFound = false;
+        if (searchReturn) {
           for (const key in searchReturn) {
             if (searchReturn[key].length > 1) {
               for (let i = 0; i < searchReturn[key].length; i += 1) {
@@ -217,14 +228,15 @@ class QuestionParser {
             }
             fuzzyFound = true;
           }
+        }
         if (fuzzyFound) {
-          return [true, fuzzyGist];
+          return QuestionParser.success(fuzzyGist);
         }
-        return [true, 'I don\'t know who or what that is.'];
+        return QuestionParser.success('I don\'t know who or what that is.');
       }
-      return [true, concept.gist];
+      return QuestionParser.success(concept.gist);
     }
-    return [true, instance.gist];
+    return QuestionParser.success(instance.gist);
   }
 
   whatDoes(t) {
@@ -256,20 +268,21 @@ class QuestionParser {
           property = instance.property(fixedPropertyName);
         }
         if (property) {
-          return [true, `${instance.name} ${fixedPropertyName} the ${property.type.name} ${property.name}.`];
+          return QuestionParser.success(`${instance.name} ${fixedPropertyName} the ${property.type.name} ${property.name}.`);
         }
-        return [true, `Sorry - I don't know that property about the ${instance.type.name} ${instance.name}.`];
+        return QuestionParser.success(`Sorry - I don't know that property about the ${instance.type.name} ${instance.name}.`);
       }
     } catch (err) {
-      return [false, 'Sorry - I can\'t work out what you\'re asking.'];
+      return QuestionParser.success('Sorry - I can\'t work out what you\'re asking.');
     }
-    return null;
+    return QuestionParser.success('Sorry - I can\'t work out what you\'re asking about.');
   }
 
   whatRelationship(t) {
     const data = t.match(/^(\bwho\b|\bwhat\b) ([a-zA-Z0-9_ ]*)/i);
     const body = data[2].replace(/\ban\b/gi, '').replace(/\bthe\b/gi, '').replace(/\ba\b/gi, '');
     const tokens = body.split(' ');
+    const uniqueResponses = new Set([]);
     let instance;
     for (let i = 0; i < tokens.length; i += 1) {
       const testString = tokens.slice(tokens.length - (i + 1), tokens.length).join(' ').trim();
@@ -283,6 +296,7 @@ class QuestionParser {
         break;
       }
     }
+
     if (instance) {
       const propertyName = tokens.splice(0, tokens.length - instance.name.split(' ').length).join(' ').trim();
       for (let i = 0; i < this.node.instances.length; i += 1) {
@@ -304,12 +318,16 @@ class QuestionParser {
           property = subject.property(fixedPropertyName);
         }
         if (property && property.name === instance.name) {
-          return [true, `${subject.name} ${fixedPropertyName} the ${property.type.name} ${property.name}.`];
+          uniqueResponses.add(`${subject.name} ${fixedPropertyName} the ${property.type.name} ${property.name}.`);
+        }
+        const responsesArray = Array.from(uniqueResponses);
+        if (responsesArray.length > 0 && i === this.node.instances.length - 1) {
+          return QuestionParser.success(responsesArray.join(' '));
         }
       }
-      return [true, `Sorry - I don't know that property about the ${instance.type.name} ${instance.name}.`];
+      return QuestionParser.success(`Sorry - I don't know that property about the ${instance.type.name} ${instance.name}.`);
     }
-    return null;
+    return QuestionParser.success('Sorry - I don\'t know the instance you\'re referring to.');
   }
 
   listInstances(t) {
@@ -324,21 +342,20 @@ class QuestionParser {
       ins = this.node.getInstances(con, true);
       s = `All instances of type '${con}':`;
     } else if (t.toLowerCase() === 'list instances') {
-      ins = this.node.instances;
+      ins = this.node.getInstances();
       s = 'All instances:';
     }
     if (ins.length === 0) {
-      return [true, 'I could not find any instances matching your query.'];
+      return QuestionParser.success('I could not find any instances matching your query.');
     }
     const names = [];
     for (let i = 0; i < ins.length; i += 1) {
       names.push(ins[i].name);
     }
-    return [true, `${s} ${names.join(', ')}`];
+    return QuestionParser.success(`${s} ${names.join(', ')}`);
   }
 
   /*
-   *
    * Search the knowledge base for an instance name similar to the one asked about.
    */
   fuzzySearch(sentence) {
@@ -348,12 +365,10 @@ class QuestionParser {
     let instancesFiltered = [];
 
     if (searchFor.indexOf(' ')) {
-      // if theres spaces then split
       multipleSearch = searchFor.split(' ');
     }
 
     if (multipleSearch) {
-      // loop through to create return string
       for (let x = 0; x < multipleSearch.length; x += 1) {
         const instancesFilteredTemp = instances.filter((input) => {
           if (input.name.toUpperCase().includes(multipleSearch[x].toUpperCase())) {
@@ -364,7 +379,6 @@ class QuestionParser {
         instancesFiltered = instancesFiltered.concat(instancesFilteredTemp);
       }
     } else {
-      // single search term
       instancesFiltered = instances.filter((input) => {
         if (input.name.toUpperCase().includes(searchFor.toUpperCase())) {
           return input;

src/RuleEngine.js

@@ -64,16 +64,15 @@ class RuleEngine {
     if (typeof objectInstance === 'string') {
       return;
     }
-    const rules = this.node.getInstances('rule');
+    for (const ruleInstance of this.node.getInstances('rule')) {
-    for (let i = 0; i < rules.length; i += 1) {
+      const rule = RuleEngine.parseRule(ruleInstance.instruction);
-      const rule = RuleEngine.parseRule(rules[i].instruction);
       if (!rule) { return; }
       if (rule.if.concept === subjectInstance.type.name) {
         if ((propertyType === 'relationship' && rule.if.relationship) || (propertyType === 'value' && rule.if.value)) {
-          const ancestorConcepts = objectInstance.type.ancestors;
+          const ancestorConcepts = objectInstance.concept.ancestors;
-          ancestorConcepts.push(objectInstance.type);
+          ancestorConcepts.push(objectInstance.concept);
-          for (let j = 0; j < ancestorConcepts.length; j += 1) {
+          for (const ancestorConcept of ancestorConcepts) {
-            if (ancestorConcepts[j].name.toLowerCase() === rule.if[propertyType].type.toLowerCase()) {
+            if (ancestorConcept.name.toLowerCase() === rule.if[propertyType].type.toLowerCase()) {
               if (rule.then.relationship && rule.then.relationship.type === subjectInstance.type.name) {
                 objectInstance.addRelationship(rule.then.relationship.label, subjectInstance, false, source);
               } else if (rule.then.value && rule.then.value.type === subjectInstance.type.name) {

test/CEParser.js

@@ -44,6 +44,22 @@ describe('CEParser', function() {
       expect(node.concepts.plant.relationships.length).to.be(1);
       expect(node.concepts.plant.relationships[0].label).to.be('grows into');
     });
+    it('prevent multi-conceptualisation', () => {
+      node.addCE('conceptualise a ~ river ~ R');
+      node.addCE('conceptualise a ~ river ~ R');
+      let counter = 0;
+      for (const concept of node.concepts) {
+        if (concept.name === 'river'){
+          counter += 1;
+        }
+      }
+      expect(counter).to.equal(1);
+    });
+    it('ensure concepts can be addressed by synonyms', () => {
+      node.addCE('conceptualise a ~ seat ~ that ~ is expressed by ~ chair and has the value V as ~ height ~');
+      node.addCE('there is a chair named chair1 that has 43cm as height');
+      expect(node.instances.chair1.height).to.equal('43cm');
+    });
   });   
   
   
@@ -90,6 +106,50 @@ describe('CEParser', function() {
       expect(node.instances.jane.subConcepts[0].name).to.be('barrister');
       expect(node.instances.jane.subConcepts[1].name).to.be('londoner');
     });
+    
+    it('prevent multi-instantiation', () => {
+      node.addCE('there is a person named Francesca');
+      node.addCE('there is a person named Francesca');
+      let counter = 0;
+      for (const instance of node.instances) {
+        if (instance.name === 'Francesca'){
+          counter += 1;
+        }
+      }
+      expect(counter).to.equal(1);
+    });
+    it('ensure instance CE is correct', () => {
+      node.addCE('there is an entity named Hagrid');
+      const hagrid = node.instances.hagrid;
+      expect(hagrid.ce).to.equal('there is a entity named \'Hagrid\'.');
+      node.addCE('the entity Hagrid is a person');
+      expect(hagrid.ce).to.equal('there is a entity named \'Hagrid\' that is a person.');
+    });
+    
+    it('ensure instances can be addressed by synonyms', () => {
+      node.addCE('conceptualise an ~ engineer ~ E');
+      node.addCE('there is a person named William that is expressed by Will');
+      node.addCE('the person Will is an engineer');
+      expect(node.instances.william.subConcepts[0].name).to.be('engineer');
+    });
+    it('ensure instances inherit properties from subConcepts', () => {
+      node.addCE('conceptualise a ~ borough ~ B');
+      node.addCE('conceptualise the londoner L ~ lives in ~ the borough B');
+      node.addCE('conceptualise the barrister B has the value V as ~ speciality ~');
+      node.addCE('there is a person named Amy that is a londoner and is a barrister');
+      node.addCE('the person Amy lives in the borough Chelsea and has \'family law\' as speciality');
+      expect(node.instances.amy.lives_in.name).to.be('Chelsea');
+      expect(node.instances.amy.speciality).to.be('family law');
+    });
+    it('ensure strings with a mix of quoted and unquoted names/values are parsed', () => {
+      node.addCE('there is a londoner named Ella that lives in the borough \'Kensington and Chelsea\'');
+      node.addCE('there is a londoner named \'Betty Hughes\' that lives in the borough Camden');
+      node.addCE('there is a londoner named Sally');
+      node.addCE('the londoner Sally lives in the borough \'Kensington and Chelsea\'');
+      expect(node.instances.ella.lives_in.name).to.be('Kensington and Chelsea');
+      expect(node.instances.betty_hughes.lives_in.name).to.be('Camden');
+      expect(node.instances.sally.lives_in.name).to.be('Kensington and Chelsea');
+    });
   });
 
   describe('Specific Examples', function() {
@@ -118,11 +178,12 @@ describe('CEParser', function() {
       expect(node.instances.fred.works_for.name).to.be('IBM');
     });
 
-    it('the person Fred works for the company IBM and is married to the person Jane and has 53 as age.', function() {
+    it('the person Fred works for the company IBM and is married to the person Jane and has 53 as age and has the city Cardiff as address.', function() {
       node.addCE('conceptualise a ~ company ~ C');
-      node.addCE('conceptualise a ~ person ~ P that ~ works for ~ the company C and ~ is married to ~ the person Q and has the value V as ~ age ~');
+      node.addCE('conceptualise a ~ city ~ C');
+      node.addCE('conceptualise a ~ person ~ P that ~ works for ~ the company C and ~ is married to ~ the person Q and has the value V as ~ age ~ and has the city C as ~ address ~');
       node.addCE('there is a person named Fred');
-      node.addCE('the person Fred works for the company IBM and is married to the person Jane and has 53 as age.');
+      node.addCE('the person Fred works for the company IBM and is married to the person Jane and has 53 as age and has the city Cardiff as address.');
       expect(node.instances.fred.works_for.name).to.be('IBM');
       expect(node.instances.fred.is_married_to.name).to.be('Jane');
       expect(node.instances.fred.age).to.be('53');
@@ -158,7 +219,5 @@ describe('CEParser', function() {
       expect(node.concepts.farmer.parents[1].name).to.be('land owner');
     });
   });
-
-
 });
 

test/QuestionParser.js

@@ -0,0 +1,40 @@
+const CENode = require('../src/CENode.js');
+const CEModels = require('../models/index.js');
+const expect = require('expect.js');
+const myName = 'User'
+const PLANETS_MODEL = [
+  "there is a rule named 'r1' that has 'if the planet C ~ orbits ~ the star D then the star D ~ is orbited by ~ the planet C' as instruction.",
+  "there is a rule named 'r2' that has 'if the planet C ~ is orbited by ~ the moon D then the moon D ~ orbits ~ the planet C' as instruction.",
+  "conceptualise a ~ celestial body ~ C.",
+  "conceptualise the celestial body C ~ orbits ~ the celestial body D and ~ is orbited by ~ the celestial body E.",
+  "conceptualise a ~ planet ~ P that is a celestial body and is an imageable thing.",
+  "conceptualise a ~ star ~ S that is a celestial body.",
+  "there is a star named sun.",
+  "there is a planet named Venus that orbits the star 'sun' and has 'media/Venus.jpg' as image.",
+  "there is a planet named Mercury that orbits the star 'sun' and has 'media/Mercury.jpg' as image."
+]
+
+let node;
+describe('CEQuestionParser', function() {
+  describe('What relation questions', function () {
+    this.timeout(2050);
+    before(function() {
+      node = new CENode(CEModels.core, PLANETS_MODEL);
+      node.attachAgent();
+      node.agent.setName('agent1');
+    });
+    it('returns the correct number of responses', (done) => {
+      const message = 'what orbits the sun?';
+      const askCard = "there is a nl card named '{uid}' that is to the agent 'agent1' and is from the individual '" + myName + "' and has the timestamp '{now}' as timestamp and has '" + message.replace(/'/g, "\\'")+"' as content.";
+      
+      node.addSentence(askCard);
+      
+      setTimeout(function() {
+        const cards = node.concepts.card.allInstances;
+        const card = cards[cards.length - 1];
+        expect(card.content).to.equal('Venus orbits the star sun. Mercury orbits the star sun.');
+        done();
+      }, 2000);
+    });
+  });
+});